Propose to refactor output normalization in several transformers #11850
+72
−65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(I attempted to make replacements if you don't mind :)
This PR will be activated when the SkyReels-V2 models' integration PR is merged into
main
.Replace
FP32LayerNorm
withAdaLayerNorm
in theWanTransformer3DModel
,WanVACETransformer3DModel
, ..., simplifying the forward pass and enhancing model parallelism compatibility.Context: #11518 (comment)
@yiyixuxu @a-r-r-o-w